Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency golangci/golangci-lint to v1.64.2 #25300

Closed
wants to merge 1 commit into from

chore(deps): update dependency golangci/golangci-lint to v1.64.2

1763be9
Select commit
Loading
Failed to load commit list.
Closed

chore(deps): update dependency golangci/golangci-lint to v1.64.2 #25300

chore(deps): update dependency golangci/golangci-lint to v1.64.2
1763be9
Select commit
Loading
Failed to load commit list.
Cirrus CI / Build for MacOS amd64+arm64 failed Feb 11, 2025 in 52s

Task Summary

Instruction lint failed in 00:37

Details

✅ 00:06 clone
✅ 00:04 prep
❌ 00:37 lint

make golangci-lint
Makefile:153: invalid `override' directive
VERSION=1.64.2 ./hack/install_golangci.sh
Installing golangci-lint v1.64.2 into ./bin/golangci-lint
golangci/golangci-lint info checking GitHub for tag 'v1.64.2'
golangci/golangci-lint info found version: 1.64.2 for v1.64.2/darwin/arm64
golangci/golangci-lint info installed ./bin/golangci-lint
hack/golangci-lint.sh run

Running golangci-lint for REMOTE
Build Tags REMOTE: remote,containers_image_openpgp
Skipped directories REMOTE: libpod/events,pkg/machine/qemu,pkg/machine/wsl,test
+ ./bin/golangci-lint run --timeout=10m --build-tags=remote,containers_image_openpgp --exclude-dirs=libpod/events,pkg/machine/qemu,pkg/machine/wsl,test
level=warning msg="[lintersdb] The linter \"exportloopref\" is deprecated (step 2) and deactivated. It should be removed from the list of disabled linters. https://golangci-lint.run/product/roadmap/#linter-deprecation-cycle"
level=warning msg="The linter 'tenv' is deprecated (since v1.64.0) due to: Duplicate feature another linter. Replaced by usetesting."
cmd/podman/registry/registry.go:88:3: nested context in function literal (fatcontext)
		cliCtx = ContextWithOptions(context.Background())
		^
cmd/podman/registry/registry.go:94:2: nested context in function literal (fatcontext)
	cliCtx = context.WithValue(ctx, PodmanOptionsKey{}, podmanOptions)
	^
pkg/machine/define/vmfile_test.go:59:2: os.Setenv() could be replaced by t.Setenv() in TestNewMachineFile (usetesting)
	os.Setenv("HOME", homedir) //nolint: tenv
	^
pkg/machine/define/vmfile_test.go:60:8: os.Setenv() could be replaced by t.Setenv() in TestNewMachineFile (usetesting)
	defer os.Setenv("HOME", oldhome)
	      ^
make: *** [golangci-lint] Error 1

Exit status: 2