-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Bump FreeBSD version to 13.4 #25288
Conversation
Version 13.3 is EOL. See https://www.freebsd.org/releases/ Signed-off-by: Jan Rodák <hony.com@seznam.cz>
@@ -322,7 +322,7 @@ freebsd_alt_build_task: | |||
TEST_FLAVOR: "altbuild" | |||
ALT_NAME: 'FreeBSD Cross' | |||
freebsd_instance: | |||
image_family: freebsd-13-3 | |||
image_family: freebsd-13-4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason to not bump to 14.2?
cc @dfr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to make minimal changes. It's a pity that no freebsd-stable
or freebsd-latest
image is available.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From https://www.freebsd.org/security/#sup 14.2 EOL is September 30 while 13.4 is June 30 already.
I would prefer to bump to 14.2 as long as it passes CI we should be good, if not then we can use 13.4 to unblock CI but we have to update at some point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it makes sense for this to be the oldest supported FreeBSD release which works with Podman, so 13.4 is probably the right choice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, lets get this merged to unblock CI
Thanks @Honny1
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Honny1, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
e7d9c61
into
containers:main
The FreeBSD build is broken due to missing FreeBSD 13.3 image, for example https://cirrus-ci.com/task/4915570123997184
Version 13.3 is EOL. See https://www.freebsd.org/releases/
Does this PR introduce a user-facing change?