Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Bump FreeBSD version to 13.4 #25288

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

Honny1
Copy link
Member

@Honny1 Honny1 commented Feb 11, 2025

The FreeBSD build is broken due to missing FreeBSD 13.3 image, for example https://cirrus-ci.com/task/4915570123997184

Version 13.3 is EOL. See https://www.freebsd.org/releases/

Does this PR introduce a user-facing change?

None

Version 13.3 is EOL. See https://www.freebsd.org/releases/

Signed-off-by: Jan Rodák <hony.com@seznam.cz>
@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none labels Feb 11, 2025
@Honny1 Honny1 marked this pull request as ready for review February 11, 2025 10:27
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 11, 2025
@@ -322,7 +322,7 @@ freebsd_alt_build_task:
TEST_FLAVOR: "altbuild"
ALT_NAME: 'FreeBSD Cross'
freebsd_instance:
image_family: freebsd-13-3
image_family: freebsd-13-4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason to not bump to 14.2?

cc @dfr

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to make minimal changes. It's a pity that no freebsd-stable or freebsd-latest image is available.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From https://www.freebsd.org/security/#sup 14.2 EOL is September 30 while 13.4 is June 30 already.

I would prefer to bump to 14.2 as long as it passes CI we should be good, if not then we can use 13.4 to unblock CI but we have to update at some point.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes sense for this to be the oldest supported FreeBSD release which works with Podman, so 13.4 is probably the right choice.

Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, lets get this merged to unblock CI

Thanks @Honny1

Copy link
Contributor

openshift-ci bot commented Feb 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Honny1, Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 11, 2025
@Luap99 Luap99 added the v5.4 label Feb 11, 2025
@rhatdan
Copy link
Member

rhatdan commented Feb 11, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 11, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit e7d9c61 into containers:main Feb 11, 2025
91 of 92 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none v5.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants