Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendor c/common@main #21416

Closed
wants to merge 1 commit into from
Closed

Vendor c/common@main #21416

wants to merge 1 commit into from

Conversation

ashley-cui
Copy link
Member

Fixes windows CI.

Does this PR introduce a user-facing change?

None

Fixes windows CI.

Signed-off-by: Ashley Cui <acui@redhat.com>
@openshift-ci openshift-ci bot added release-note-none do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jan 29, 2024
@ashley-cui ashley-cui marked this pull request as ready for review January 29, 2024 20:29
Copy link
Contributor

openshift-ci bot commented Jan 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashley-cui

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jan 29, 2024
@TomSweeneyRedHat
Copy link
Member

Assuming eventual happy tests
LGTM

@mheon
Copy link
Member

mheon commented Jan 29, 2024

Docker-py tests look... suspicious. Restarted.

@mheon
Copy link
Member

mheon commented Jan 29, 2024

/lgtm
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 29, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 29, 2024
@ashley-cui
Copy link
Member Author

ashley-cui commented Jan 29, 2024

Compose and api and docker-py say the same thing. Looking...

Copy link

Cockpit tests failed for commit e254117. @martinpitt, @jelly, @mvollmer please check.

@ashley-cui
Copy link
Member Author

ashley-cui commented Jan 29, 2024

@mheon containers/common#1820 breaks podman tests 😢

@mheon
Copy link
Member

mheon commented Jan 29, 2024

Um. Let me see if adding it to my PR fixes things.

@mheon
Copy link
Member

mheon commented Jan 29, 2024

Threw it in #21339 - let's see if that fixes things

@ashley-cui ashley-cui closed this Jan 31, 2024
@stale-locking-app stale-locking-app bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Apr 30, 2024
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators Apr 30, 2024
@ashley-cui ashley-cui deleted the winfix branch June 17, 2024 14:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants