-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vendor c/common@main #21416
Vendor c/common@main #21416
Conversation
Fixes windows CI. Signed-off-by: Ashley Cui <acui@redhat.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ashley-cui The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Assuming eventual happy tests |
Docker-py tests look... suspicious. Restarted. |
/lgtm |
Compose and api and docker-py say the same thing. Looking... |
Cockpit tests failed for commit e254117. @martinpitt, @jelly, @mvollmer please check. |
@mheon containers/common#1820 breaks podman tests 😢 |
Um. Let me see if adding it to my PR fixes things. |
Threw it in #21339 - let's see if that fixes things |
Fixes windows CI.
Does this PR introduce a user-facing change?