Refactor: replace raw loops with funcs from slices and maps #1784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhatdan
reviewed
Jan 4, 2024
There was a problem hiding this comment.
Thanks Nice work, one Nit
LGTM
@Luap99 @vrothberg @mheon @ashley-cui PTAL
|
Sure, LGTM modulo Dan's comment. |
Signed-off-by: Oleksandr Redko <Oleksandr_Redko@epam.com>
|
/hold |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexandear, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces raw loops with functions from slices and maps packages. By doing this, we are simplifying our code base, enhancing readability, and improving maintainability.
Also, deprecate unneeded function
util.StringInSlicethat can be replaced withslices.Contains.When we upgrade to Go 1.21,
golang.org/x/exp/sliceswill be replaced byslicesfrom std.