Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If it failed to delete the blob cache, residual cache may occur. #618

Open
shitou12345678 opened this issue Oct 10, 2024 · 3 comments
Open

Comments

@shitou12345678
Copy link

shitou12345678 commented Oct 10, 2024

If it failed to delete the blob cache, residual cache may occur. Is there any other way to handle the problem?

	if info.Kind == snapshots.KindCommitted {
		blobDigest := info.Labels[snpkg.TargetLayerDigestLabel]
		go func() {
			if err := o.fs.RemoveCache(blobDigest); err != nil {
				log.L.WithError(err).Errorf("Failed to remove cache %s", blobDigest)
			}
		}()
	}
@shitou12345678 shitou12345678 changed the title If it failed to be delete the blob cache, residual cache may occur. If it failed to delete the blob cache, residual cache may occur. Oct 10, 2024
@imeoer
Copy link
Collaborator

imeoer commented Oct 11, 2024

@shitou12345678 Maybe we need to remove cache synchronously? cc @changweige

@changweige
Copy link
Member

Generally, it can hardly fail to delete blob cache stuff. Can you see the particular error when it failed? Even we migrate a synchronously way to remove blob cache, it still fails.

@shitou12345678
Copy link
Author

In the nydus component, i haven't had such a problem. But in fact, deleting the cache and the kernel calling the inuse interface may occur the error ”device or resource busy”, so it may lead to residual.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants