Skip to content

[Tigron]: DataTemp.SaveToWriter method #4137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

apostasie
Copy link
Contributor

@apostasie apostasie commented Apr 19, 2025

On top of #4122.
Broken out of #4129.

This is a small addition to the DataTemp interface, allowing tests author to get a Writer to a managed temporary file.

This is of particular interest for tests that need to create temporary resources with systems expecting an io.Writer. For example: pem.Encode.

Next PR will re-jiggle x509 manipulation and leverage this.

@apostasie apostasie marked this pull request as draft April 19, 2025 17:59
@apostasie apostasie mentioned this pull request Apr 19, 2025
@apostasie apostasie marked this pull request as ready for review April 19, 2025 18:06
@apostasie apostasie changed the title [Tigron]: data SaveToWriter method [Tigron]: DataTemp.SaveToWriter method Apr 19, 2025
@apostasie
Copy link
Contributor Author

Failure is #4132

Signed-off-by: apostasie <spam_blackhole@farcloser.world>
@apostasie apostasie force-pushed the tigron-2025-04-data-save-to-writer branch from bf4dcd4 to 2b6294d Compare April 21, 2025 04:33
@AkihiroSuda AkihiroSuda added this to the v2.0.5 milestone Apr 21, 2025
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda merged commit 8790fae into containerd:main Apr 21, 2025
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants