fix: prevent panic in nydus snapshotter inspect #3835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apostasie
suggested changes
Jan 25, 2025
| image.Author = imgOCI.History[len(imgOCI.History)-1].Author | ||
| if !imgOCI.History[len(imgOCI.History)-1].Created.IsZero() { | ||
| image.Created = imgOCI.History[len(imgOCI.History)-1].Created.Format(time.RFC3339Nano) | ||
| image.Author = imgOCI.History[len(imgOCI.History)-1].Author |
There was a problem hiding this comment.
Does Author have to be inside the if test?
There was a problem hiding this comment.
Does
Authorhave to be inside the if test?
Oops, nice catch! The Author doesn't have to be inside the if test.🙇
Signed-off-by: Ruihua Wen <spiffyeight77@gmail.com>
SpiffyEight77
force-pushed
the
fix/issue-3755
branch
from
2bd7c9a to
6e5e943
Compare
apostasie
approved these changes
Jan 25, 2025
|
LGTM @fahedouch if you are around for a review ^ |
fahedouch
reviewed
Jan 25, 2025
| @@ -340,7 +340,9 @@ func ImageFromNative(nativeImage *native.Image) (*Image, error) { | |||
|
|
|||
| if len(imgOCI.History) > 0 { | |||
| image.Comment = imgOCI.History[len(imgOCI.History)-1].Comment | |||
| image.Created = imgOCI.History[len(imgOCI.History)-1].Created.Format(time.RFC3339Nano) | |||
| if !imgOCI.History[len(imgOCI.History)-1].Created.IsZero() { | |||
| image.Created = imgOCI.History[len(imgOCI.History)-1].Created.Format(time.RFC3339Nano) | |||
There was a problem hiding this comment.
Is it possible to have len(imgOCI.History) = 0?
if yes we need an additional check to avoid slice out-of-range error
There was a problem hiding this comment.
We are already testing for that: if len(imgOCI.History) > 0 {
There was a problem hiding this comment.
cool. Sorry I was reviewing with my phone.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description