Fix login persistence regression against Hub #3484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Login no longer persists for Docker Hub, as a mistake in the code was not using the special case Docker Hub key to save in the store. Signed-off-by: apostasie <spam_blackhole@farcloser.world>
apostasie
force-pushed
the
fix-login-regression
branch
from
71a8d29 to
5cdb3e0
Compare
|
@AkihiroSuda this one is ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Login no longer persists for Docker Hub, as a mistake in the code was not using the special case Docker Hub key to save in the store.
Incidentally, we should start testing more against Hub generally to avoid things like that.
That implies creating a test account over there, and issuing a read-only token to be added here.