Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3452: Filter Volumes by name if any of the names match #3482

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

manugupt1
Copy link
Contributor

@manugupt1 manugupt1 commented Oct 2, 2024

Fixes #3452

@apostasie
Copy link
Contributor

@manugupt1 CI is bust rn - #3479

Looking into it now.

@manugupt1
Copy link
Contributor Author

@apostasie no worries! take your time.

Signed-off-by: Manu Gupta <manugupt1@gmail.com>
@manugupt1 manugupt1 changed the title 3452: Filter Volumes if any of them match rather than close early 3452: Filter Volumes by name if any of the names match Oct 2, 2024
@manugupt1
Copy link
Contributor Author

Cc @apostasie fyi! Ty for your help

@apostasie
Copy link
Contributor

Cc @apostasie fyi! Ty for your help

Yw!
Thanks for fixing this issue @manugupt1 - LGTM.

cc @djdongjin @AkihiroSuda

Copy link
Member

@djdongjin djdongjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@djdongjin djdongjin added this to the v2.0.0 milestone Oct 2, 2024
@djdongjin djdongjin merged commit ca69b10 into containerd:main Oct 2, 2024
22 checks passed
@manugupt1 manugupt1 deleted the fix-volume-filter branch October 2, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

volume (probably others) filter behavior is inconsistent with Docker
3 participants