Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add transformer/serializer/deserializer for Gcstd_eval #9

Open
nlevenson opened this issue Mar 16, 2021 · 0 comments
Open

Add transformer/serializer/deserializer for Gcstd_eval #9

nlevenson opened this issue Mar 16, 2021 · 0 comments

Comments

@nlevenson
Copy link

In Gcapp.write_eval_set_ext, we do a little transformation from Gcstd_eval to JSON (which we ultimately dump as YAML). Similarly, in Gcapp.load_eval_set_ext, we rip a little forEach loop to set all the hashes in our new Gcstd_eval object.

Could this be nicer by moving this activity to the Gcstd_eval class?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant