Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should Gcstd_eval.from_nodes perform more validation of its arguments? #22

Open
nlevenson opened this issue Mar 17, 2021 · 0 comments
Open

Should Gcstd_eval.from_nodes perform more validation of its arguments? #22

nlevenson opened this issue Mar 17, 2021 · 0 comments

Comments

@nlevenson
Copy link

  1. Should we prevent the user from creating an evaluation set from a standard that isn't a correct instance of its schema? The downside to this is that the function would additionally require the user to specify a schema.
  2. If we do some validation, should we do ALL validation? E.g., ensure that nums is > 0, etc?
@nlevenson nlevenson changed the title Should Gceval.from_nodes perform more validation of its arguments? Should Gcstd_eval.from_nodes perform more validation of its arguments? Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nlevenson