Skip to content
This repository was archived by the owner on May 28, 2021. It is now read-only.

[client] Restore state test #1026

Open
LayneHaber opened this issue Apr 15, 2020 · 0 comments
Open

[client] Restore state test #1026

LayneHaber opened this issue Apr 15, 2020 · 0 comments
Labels
Bug Something isn't working p1 Bugs/Tests/Blockers Bugs that break things but no loss of funds + Test improvements + PRIORITY blockers for customers.

Comments

@LayneHaber
Copy link
Contributor

LayneHaber commented Apr 15, 2020

Describe the bug
This test only passes because of a special case in the listener error handling, here. The bug is likely a result of listeners not being properly cleaned from the channel provider on restart

When you run the test, you will see the logs:

Reclaiming pending async transfers
[NodeApiClient] Node responded to indra7dvysa8ze5qfqkPLXfZup56omcwtQyccgcW9Xic7TCNZ2fjEEf.transfer request in 17 ms
[ConnextClient] Reclaiming transfer 0x45d96adc2ce5f9c49f19db10c81fd4d6feaadf47d496ea69948fe1079eddd580
[ResolveLinkedTransferController] Resolving link transfer with id 0x45d96adc2ce5f9c49f19db10c81fd4d6feaadf47d496ea69948fe1079eddd580
[CF-ProposeProtocol] Response started
[ConnextListener] Done processing propose install event in 1 ms
[ConnextListener] Done processing propose install event in 2 ms

Notice the two Done processing.. event logs when there should only be one.

@LayneHaber LayneHaber added the Needs Triage Needs to be looked at and prioritized. label Apr 15, 2020
@ArjunBhuptani ArjunBhuptani added Bug Something isn't working p1 Bugs/Tests/Blockers Bugs that break things but no loss of funds + Test improvements + PRIORITY blockers for customers. and removed Needs Triage Needs to be looked at and prioritized. labels May 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Something isn't working p1 Bugs/Tests/Blockers Bugs that break things but no loss of funds + Test improvements + PRIORITY blockers for customers.
Projects
None yet
Development

No branches or pull requests

2 participants