Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add py-rattler-lock #510

Merged
merged 33 commits into from
Feb 20, 2024

Conversation

tarunps
Copy link
Contributor

@tarunps tarunps commented Feb 5, 2024

No description provided.

@baszalmstra
Copy link
Collaborator

Looks good! Im just missing tests!

@tarunps
Copy link
Contributor Author

tarunps commented Feb 5, 2024

Let me just add them

@tarunps tarunps requested review from wolfv and baszalmstra February 7, 2024 09:18
Copy link
Collaborator

@baszalmstra baszalmstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the way you construct a lock file could really be improved. What would you like the API from python to be? Maybe you can come close to that?

We could also merge this PR without the construction part and create a seperate PR for that?

@baszalmstra baszalmstra merged commit 8f0ced2 into conda:main Feb 20, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants