feat: add support for layered package cache #1003
Conversation
kelvinou01
changed the title
|
Hi @kelvinou01 - I also started hacking on this a bit but it looks like you are already much further progressed :) Here was my attempt: #998 |
|
@kelvinou01 is this pr ready? |
|
it seems the pr does not contains the changes of the config key. |
@gzm55 not yet, is there an urgent need for it? |
|
no urgent need. but expect this feature for multi-user environment |
|
when select a read or write cache, can we prefer the one from which we can make a hard link? |
|
@gzm55 I see how that can be useful! Do you think this feature is necessary to introduce with this PR, or can we do it in a subsequent one as i mentioned above? |
I think a subsequent pr for the feature mentioned above is ok. |
| fn(PathBuf) -> _, | ||
| Pin<Box<dyn Future<Output = Result<(), _>> + Send>>, | ||
| std::io::Error, |
There was a problem hiding this comment.
Yes unfortunately, as the compiler has to infer the types somehow if we're passing in None for fetch and reporter.
One way around this would be to assign default types to F, Fut, E during the declaration of validate_package_common<F, Fut, E>, but that feature is being phased out of Rust.
| } | ||
|
|
||
| /// Validate the package, and throw if invalid. | ||
| pub async fn validate_or_throw( |
There was a problem hiding this comment.
This doesnt really "throw" anything. Maybe call try_validate?
There was a problem hiding this comment.
You're right, thanks!
|
|
||
| /// Constructs a new [`PackageCache`] located at the specified paths. | ||
| /// Read-only layers are queried first. | ||
| /// Within read-only layers, the ordering is defined in this constructor. Ditto for writable layers. |
There was a problem hiding this comment.
I dont fully understand this comment and I also dont see how it relates to the code? To me it makes most sense to pass in the paths in the order the user wants the layers to be ordered.
I would assume you look through the layers in the order they are passed in, and only write to the first writable layer.
There was a problem hiding this comment.
Seems like I didn't make the comment clear. What I meant was, the querying order is defined by
- Primary key: read-only before write-only
- Secondary key: order it was passed into the constructor
But now that I think about it, querying all layers in the order passed into the constructor makes more sense.
| /// | ||
| /// The permissions are checked at the time of the function call. | ||
| pub fn split_layers(&self) -> (Vec<&PackageCacheLayer>, Vec<&PackageCacheLayer>) { | ||
| let readonly_layers = self |
There was a problem hiding this comment.
There was a problem hiding this comment.
Thank you for the tip ^^ added this to the code
…ered-package-cache
Description
As per #43, we want to implement layered package caches for Rattler.
Stuff to note
PackageCacheErrora#[non_exhaustive]enum, and modified some variants.Old PR for ref