fix: clippy errors and warnings

Author: baszalmstra

crates/rattler-bin/src/commands/create.rs

@@ -192,8 +192,7 @@ pub async fn create(opt: Opt) -> anyhow::Result<()> {
                         name: elems[0].try_into()?,
                         version: elems
                             .get(1)
-                            .map(|s| Version::from_str(s))
-                            .unwrap_or(Version::from_str("0"))
+                            .map_or(Version::from_str("0"), |s| Version::from_str(s))
                             .expect("Could not parse virtual package version"),
                         build_string: (*elems.get(2).unwrap_or(&"")).to_string(),
                     })

crates/rattler_conda_types/src/platform.rs

@@ -37,7 +37,7 @@ pub enum Platform {
 
 impl PartialOrd for Platform {
     fn partial_cmp(&self, other: &Self) -> Option<Ordering> {
-        self.as_str().partial_cmp(other.as_str())
+        Some(self.cmp(other))
     }
 }
 
@@ -270,7 +270,7 @@ impl FromStr for Platform {
             string => {
                 return Err(ParsePlatformError {
                     string: string.to_owned(),
-                })
+                });
             }
         })
     }
@@ -390,7 +390,7 @@ impl FromStr for Arch {
             string => {
                 return Err(ParseArchError {
                     string: string.to_owned(),
-                })
+                });
             }
         })
     }

crates/rattler_conda_types/src/repo_data/patches.rs

@@ -197,7 +197,7 @@ impl RepoData {
             }
         }
 
-        self.removed.extend(removed.into_iter());
+        self.removed.extend(removed);
     }
 }
 

crates/rattler_solve/src/libsolv_c/wrapper/queue.rs

@@ -70,7 +70,7 @@ impl QueueRef<'_> {
     ///
     /// Safety: the queue must not have been freed
     pub(super) unsafe fn from_ffi_queue<T>(_source: &T, queue: ffi::Queue) -> QueueRef<'_> {
-        QueueRef(queue, PhantomData::default())
+        QueueRef(queue, PhantomData)
     }
 
     /// Returns an iterator over the ids of the queue

crates/rattler_solve/src/libsolv_c/wrapper/repo.rs

@@ -34,7 +34,7 @@ impl<'pool> Repo<'pool> {
         unsafe {
             let repo_ptr = ffi::repo_create(pool.raw_ptr(), c_url.as_ptr());
             let non_null_ptr = NonNull::new(repo_ptr).expect("repo ptr was null");
-            Repo(non_null_ptr, PhantomData::default())
+            Repo(non_null_ptr, PhantomData)
         }
     }
 

crates/rattler_solve/src/libsolv_c/wrapper/repodata.rs

@@ -16,7 +16,7 @@ impl Repodata<'_> {
     ) -> Repodata<'a> {
         Repodata(
             NonNull::new(ptr).expect("repodata ptr was null"),
-            PhantomData::default(),
+            PhantomData,
         )
     }
 

crates/rattler_solve/src/libsolv_c/wrapper/solver.rs

@@ -21,7 +21,7 @@ impl<'pool> Solver<'pool> {
     /// Constructs a new Solver from the provided libsolv pointer. It is the responsibility of the
     /// caller to ensure the pointer is actually valid.
     pub(super) unsafe fn new(_pool: &Pool, ptr: NonNull<ffi::Solver>) -> Solver<'_> {
-        Solver(ptr, PhantomData::default())
+        Solver(ptr, PhantomData)
     }
 
     /// Returns a raw pointer to the wrapped `ffi::Solver`, to be used for calling ffi functions

crates/rattler_solve/src/libsolv_c/wrapper/transaction.rs

@@ -25,7 +25,7 @@ impl Transaction<'_> {
         _solver: &'a Solver<'a>,
         ptr: NonNull<ffi::Transaction>,
     ) -> Transaction<'a> {
-        Transaction(ptr, PhantomData::default())
+        Transaction(ptr, PhantomData)
     }
 
     /// Returns a raw pointer to the wrapped `ffi::Transaction`, to be used for calling ffi functions

crates/rattler_solve/src/resolvo/mod.rs

@@ -56,7 +56,7 @@ impl<'a> From<NamelessMatchSpec> for SolverMatchSpec<'a> {
     fn from(value: NamelessMatchSpec) -> Self {
         Self {
             inner: value,
-            _marker: PhantomData::default(),
+            _marker: PhantomData,
         }
     }
 }