Windows: Fix OpenMP Linkage #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ax3l
requested review from
RTSandberg,
RemiLehe,
cemitch99 and
n01r
as code owners
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Unknown OpenMP types at link type if used in public symbols.
WeiqunZhang
reviewed
Mar 12, 2024
recipe/bld.bat
Outdated
| @@ -5,6 +5,10 @@ | |||
| if not exist %LIBRARY_PREFIX%\bin md %LIBRARY_PREFIX%\bin | |||
| if errorlevel 1 exit 1 | |||
|
|
|||
| :: OpenMP flags | |||
| set "CXXFLAGS=%CXXFLAGS% -openmp" | |||
| set "LDFLAGS=%LDFLAGS% -openmp" | |||
There was a problem hiding this comment.
It does not seem to know about the -openmp flag.
Should we try something like -DCMAKE_EXE_LINKER_FLAGS="-fopenmp" suggested here, https://discourse.cmake.org/t/openmp-linking-errors-on-windows-using-ninja-and-clang/7246
There was a problem hiding this comment.
That should end up in LDFLAGS as well though...
https://cmake.org/cmake/help/latest/variable/CMAKE_EXE_LINKER_FLAGS.html
On my laptop:
$ lld-link -openmp
lld-link: warning: ignoring unknown argument '-openmp'
lld-link: error: no input files
$ lld-link -fopenmp
lld-link: warning: ignoring unknown argument '-fopenmp'
lld-link: error: no input files
|
Merging for now to fix BLAST-ImpactX/impactx#550 |
|
Ouch, merging this was a mistake. Reverted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows shows unknown OpenMP types at link type if used in public symbols.
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)