Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libsodium: implement better workaround for the lack of automatic interaction between MSBuildToolchain & MSBuild #15041

Merged

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented Dec 31, 2022

Less patches, and future proof. Workaround will be removed once conan-io/conan#12817 available in conan client.


@SpaceIm SpaceIm force-pushed the libsodium-better-msbuild-fix branch from 3b69354 to eeb24a0 Compare December 31, 2022 17:50
@ghost
Copy link

ghost commented Dec 31, 2022

I detected other pull requests that are modifying libsodium/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@conan-center-bot

This comment has been minimized.

@SpaceIm SpaceIm force-pushed the libsodium-better-msbuild-fix branch from eeb24a0 to 9afcad2 Compare January 1, 2023 09:56
@SpaceIm SpaceIm changed the title libsodium: implement better workaround for lack of robust injection of MSBuildToolchain in MSBuild libsodium: implement better workaround for the lack of automatic interaction between MSBuildToolchain & MSBuild Jan 1, 2023
@SpaceIm SpaceIm force-pushed the libsodium-better-msbuild-fix branch from 9afcad2 to d06bafe Compare January 1, 2023 10:28
@SpaceIm SpaceIm force-pushed the libsodium-better-msbuild-fix branch from d06bafe to 4a2cbbb Compare January 1, 2023 11:01
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@SpaceIm SpaceIm force-pushed the libsodium-better-msbuild-fix branch from 813735a to a78aac1 Compare January 1, 2023 17:39
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline

All green in build 7 (a78aac1a46ec79a5f923e6c303ce788467e17ac4):

  • libsodium/1.0.18@:
    All packages built successfully! (All logs)

  • libsodium/cci.20220430@:
    All packages built successfully! (All logs)


Conan v2 pipeline (informative, not required for merge)

All green in build 7 (a78aac1a46ec79a5f923e6c303ce788467e17ac4):

  • libsodium/1.0.18@:
    All packages built successfully! (All logs)

  • libsodium/cci.20220430@:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit b2c8540 into conan-io:master Jan 2, 2023
@SpaceIm SpaceIm deleted the libsodium-better-msbuild-fix branch January 2, 2023 15:12
AbrilRBS pushed a commit to AbrilRBS/conan-center-index that referenced this pull request Jan 16, 2023
…of automatic interaction between MSBuildToolchain & MSBuild

* implement better workaround for the lack of automatic interaction between MSBuild & MSBuildToolchain

* improve install of .lib & .dll
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants