Add USDC market on Scroll mainnet #824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isabellewei
force-pushed
the
isabellewei/scroll-mainnet
branch
from
493bae4 to
3bde642
Compare
kevincheng96
reviewed
Feb 2, 2024
deployments/scroll/usdc/migrations/1706149385_configurate_and_ens.ts
Outdated
Show resolved
Hide resolved
| @@ -108,7 +117,17 @@ export default async function relayScrollMessage( | |||
| console.log( | |||
| `[${governanceDeploymentManager.network} -> ${bridgeDeploymentManager.network}] Bridged over ${amount} of WETH to user ${to}` | |||
| ); | |||
| } else if (target === bridgeReceiver.address) { | |||
| } else if (target === l2WstETHGateway.address){ | |||
There was a problem hiding this comment.
Is this just a generic ERC20 gateway? I don't think we need a case for every ERC20 unless they all go through different gateways.
There was a problem hiding this comment.
it's specifically for bridging WstETH. Even though on the L2 side it's basically a generic ERC20 token on the L1 side it's different
isabellewei
force-pushed
the
isabellewei/scroll-mainnet
branch
from
211fa26 to
12f8856
Compare
deployments/scroll/usdc/migrations/1706149385_configurate_and_ens.ts
Outdated
Show resolved
Hide resolved
kevincheng96
approved these changes
Feb 22, 2024
deployments/scroll/usdc/migrations/1706149385_configurate_and_ens.ts
Outdated
Show resolved
Hide resolved
kevincheng96
merged commit 6613ce8
into
compound-finance:isabellewei/scroll-deploy
3 of 26 checks passed
kevincheng96
added a commit
that referenced
this pull request
Mar 28, 2024
* debug * update price feed * update config * temp workaround * add scroll to scenarios * uncomment spider debug messages * add scroll relations * catch failed spider crawls * Fix spider for scroll * update bridge receiver to be compatible with scroll bridge * update relations * Modified deployment roots from GitHub Actions * remove console.log * rename scroll messenger * add scroll to governance scenarios * adapt scroll relay message fn * fix unit tests * rename contracts and update message relaying * update scroll testnet block explorer URL * remove base fee * fix scroll l2 sender address * remove old roots * fix type errors * Modified deployment roots from GitHub Actions * proposal for intializing usdc market on scroll goerli * add configurator to scroll relations * PR comments * add docstrings * emit event when intializing ScrollBridgeReceiver * PR comments * update comment * add usdc market on scroll mainnet * fix wseth * create migration * use gauntlet recommended parameters * lint and fix timelock params * set rewards speed to 0 * add pause guardian * fix scientific notation * add scroll mainnet roots * update scroll relations for wsteth * PR comments * update wsteth/USD price feed to exchange rate based * Modified deployment roots from GitHub Actions * update proposal description * update scroll governance proposal to bridge USDC instead of COMP * final PR comments * set message value on propsal actions --------- Co-authored-by: Isabelle Wei <isabellewei@Isabelles-MacBook-Pro.local> Co-authored-by: isabelle <isabelle@scroll.io> Co-authored-by: kevincheng96 <kevincheng96@hotmail.com> Co-authored-by: GitHub Actions Bot <>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WETH and wstETH on USDC market