Replace general write int func with specific ones

No huge performance win or anything—just makes it more like the reader

lib/nocturne.rb

@@ -52,7 +52,7 @@ def change_db(db)
     @conn.begin_command
 
     @conn.write_packet do |packet|
-      packet.int(1, Protocol::COM_INIT_DB)
+      packet.int8(Protocol::COM_INIT_DB)
       packet.str(db)
     end
 
@@ -73,7 +73,7 @@ def ping
     @conn.begin_command
 
     @conn.write_packet do |packet|
-      packet.int(1, Protocol::COM_PING)
+      packet.int8(Protocol::COM_PING)
     end
 
     @conn.read_packet do |payload|
@@ -89,7 +89,7 @@ def close
     @conn.begin_command
 
     @conn.write_packet do |packet|
-      packet.int(1, Protocol::COM_QUIT)
+      packet.int8(Protocol::COM_QUIT)
     end
 
     @conn.close

lib/nocturne/protocol/handshake.rb

@@ -63,13 +63,15 @@ def server_handshake
         @options[:read_timeout] = original_read_timeout
       end
 
+      UNUSED = "\0".b * 23
+
       def ssl_request
         @conn.write_packet do |packet|
           # TODO don't hardcode all this
-          packet.int(4, 0x018aaa00) # capabilities (ssl capability set)
-          packet.int(4, 0xffffff) # max packet size
-          packet.int(1, 0x2d) # charset
-          packet.int(23, 0) # unused
+          packet.int32(0x018aaa00) # capabilities (ssl capability set)
+          packet.int32(0xffffff) # max packet size
+          packet.int8(0x2d) # charset
+          packet.str(UNUSED)
         end
 
         @conn.upgrade
@@ -78,18 +80,18 @@ def ssl_request
       def client_handshake
         @conn.write_packet do |packet|
           # TODO don't hardcode all this
-          packet.int(4, 0x018aa200) # capabilities
-          packet.int(4, 0xffffff) # max packet size
-          packet.int(1, 0x2d) # charset
-          packet.int(23, 0) # unused
+          packet.int32(0x018aa200) # capabilities (ssl capability set)
+          packet.int32(0xffffff) # max packet size
+          packet.int8(0x2d) # charset
+          packet.str(UNUSED)
 
           packet.nulstr(@options[:username] || "root")
 
           if @auth_plugin_name == "mysql_native_password" && password?
-            packet.int(1, 20)
+            packet.int8(20)
             packet.str(mysql_native_password(@auth_plugin_data))
           else
-            packet.int(1, 0)
+            packet.int8(0)
           end
 
           packet.nulstr(@auth_plugin_name)

lib/nocturne/protocol/query.rb

@@ -16,7 +16,7 @@ def query(sql)
         @conn.begin_command
 
         @conn.write_packet do |packet|
-          packet.int(1, Protocol::COM_QUERY)
+          packet.int8(Protocol::COM_QUERY)
           packet.str(sql)
         end
 

lib/nocturne/write/packet.rb

@@ -26,12 +26,15 @@ def empty?
         @buffer.empty?
       end
 
-      def int(bytes, value)
-        while bytes > 0
-          @buffer << (value & 0xff)
-          value >>= 8
-          bytes -= 1
-        end
+      def int8(value)
+        @buffer << (value & 0xFF)
+      end
+
+      def int32(value)
+        @buffer << (value & 0xFF)
+        @buffer << ((value >> 8) & 0xFF)
+        @buffer << ((value >> 16) & 0xFF)
+        @buffer << ((value >> 24) & 0xFF)
       end
 
       def str(value)