Use correct filetype for malicious consent forms in tests

spec/support/unaccompanied_minor_helpers.rb

@@ -345,7 +345,7 @@ def uam_enter_minors_contact_details(email: nil, confirm_email: nil, telephone:
   end
 
   def make_malicious_file
-    file = Tempfile.new('malicious-test-file')
+    file = Tempfile.new(['malicious-test-file', '.pdf'])
     # We need to construct the EICAR test string from multiple parts because if it appears in it's entirely in the
     # source file our dev machine's AV will be unhappy
     file.write('X5O!P%@AP[4\PZX54(P^)7CC)7}$EICAR-' + 'STANDARD-ANTIVIRUS-TEST-FILE!$H+H*')

spec/system/unaccompanied_minor_file_upload_spec.rb

@@ -76,11 +76,16 @@
 
       expect(page).to have_content("Upload the UK sponsorship arrangement consent form")
 
-      malicious_file = make_malicious_file
-      attach_file("unaccompanied-minor-uk-parental-consent-field", malicious_file.path)
-      click_button("Continue")
-
-      expect(page).to have_content(malicious_file_message)
+      begin
+        malicious_file = make_malicious_file
+        attach_file("unaccompanied-minor-uk-parental-consent-field", malicious_file.path)
+        click_button("Continue")
+
+        expect(page).to have_content(malicious_file_message)
+      ensure
+        malicious_file.close
+        malicious_file.unlink
+      end
     end
 
     it "gets rejected trying to upload a malicious UK consent form" do
@@ -89,11 +94,16 @@
 
       expect(page).to have_content("Upload the Ukraine certified consent form")
 
-      malicious_file = make_malicious_file
-      attach_file("unaccompanied-minor-ukraine-parental-consent-field", malicious_file.path)
-      click_button("Continue")
+      begin
+        malicious_file = make_malicious_file
+        attach_file("unaccompanied-minor-ukraine-parental-consent-field", malicious_file.path)
+        click_button("Continue")
 
-      expect(page).to have_content(malicious_file_message)
+        expect(page).to have_content(malicious_file_message)
+      ensure
+        malicious_file.close
+        malicious_file.unlink
+      end
     end
   end
 end