Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add grid layout and box container layout classes #158

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Add grid layout and box container layout classes #158

merged 1 commit into from
Apr 29, 2024

Conversation

kateriley1
Copy link
Contributor

@kateriley1 kateriley1 commented Apr 29, 2024 •
edited
Loading

Pull request checklist

  • Add a descriptive message for this change to the PR
  • Run black ./ locally
  • Run pylint gov_uk_dashboards locally
  • Run python -u -m pytest --headless tests locally
  • Include screenshot for any visual changes
  • Incremented the version in setup.py

PR Description:

Add 3 new classes for creating grid layouts & box container layout

  • three_column_grid_layout
  • two_column_grid_layout
  • box_container_layout

@kateriley1 kateriley1 changed the title wip Add grid layout and box container layout classes Apr 29, 2024
Ellie-Brakoniecki
Ellie-Brakoniecki approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@Ellie-Brakoniecki Ellie-Brakoniecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea to move these here:)

@kateriley1 kateriley1 merged commit ade69b6 into main Apr 29, 2024
7 checks passed
@kateriley1 kateriley1 deleted the grid-classes branch April 29, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ellie-Brakoniecki Ellie-Brakoniecki Ellie-Brakoniecki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kateriley1 @Ellie-Brakoniecki