Resolve DeprecationWarning #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
samuelhwilliams
commented
Dec 17, 2024
•
samuelhwilliams
commented
fsd_utils/logging/__init__.py:2: in <module>
from . import logging
fsd_utils/logging/logging.py:13: in <module>
from pythonjsonlogger.jsonlogger import JsonFormatter as
BaseJSONFormatter
.tox/py3.10-flask2.2-sqlalchemy2/lib/python3.10/site-packages/pythonjsonlogger/jsonlogger.py:11:
in <module>
warnings.warn(
E DeprecationWarning: pythonjsonlogger.jsonlogger has been moved to
pythonjsonlogger.json
Update version to 5.3.1
samuelhwilliams
force-pushed
the
bau/fix-deprecation-warnings
branch
from
df27deb to
75df227
Compare
sfount
approved these changes
Dec 17, 2024
samuelhwilliams
added a commit
that referenced
this pull request
Dec 23, 2024
This was added in #200 but appears to be from a version of python-json-logger we aren't using yet - so was premature.
samuelhwilliams
added a commit
that referenced
this pull request
Dec 23, 2024
This was added in #200 but appears to be from a version of python-json-logger we aren't using yet - so was premature.
samuelhwilliams
added a commit
that referenced
this pull request
Dec 23, 2024
This was added in #200 but appears to be from a version of python-json-logger we aren't using yet - so was premature.
samuelhwilliams
added a commit
that referenced
this pull request
Dec 23, 2024
Depending on what version of python-json-logger is installed, the JsonFormatter is in a different module. This change fixes the broken PR #200 which didn't account for apps still using python-json-logger v2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.