Allow healthcheck to work in host_matching mode #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a Flask app is running in `host_matching` mode, it will only route inbound requests to registered endpoints that set a `host` parameter on the route. In order to register a view against all hosts, you can use route variables like normal, so `<host>` will match any route and pass the value through as the variable `host` to the view.
samuelhwilliams
force-pushed
the
bau/healthcheck-any-host
branch
from
d932b4c to
2d522ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a Flask app is running in
host_matchingmode, it will only route inbound requests to registered endpoints that set ahostparameter on the route.In order to register a view against all hosts, you can use route variables like normal, so
<host>will match any route and pass the value through as the variablehostto the view.