Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade pre-commit #179

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Upgrade pre-commit #179

merged 1 commit into from
Oct 24, 2024

Conversation

samuelhwilliams
Copy link
Contributor

Change description

Bumps our local pre-commit version to be >=4.0. This matches what runs in pre-commit.ci, so is best to keep roughly in sync.

In particular this bump has been prompted by CI failures on the assessment-store, where one of the installed hooks is incompatible with v4 of pre-commit because the python_venv "language" has been removed. We don't see this issue locally on that repo because we're still running an older version of pre-commmit.

MarcUsher
MarcUsher previously approved these changes Oct 24, 2024
Copy link

@MarcUsher MarcUsher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫡

Copy link

@MarcUsher MarcUsher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving 🫡

@samuelhwilliams samuelhwilliams merged commit b03505e into main Oct 24, 2024
8 checks passed
@samuelhwilliams samuelhwilliams deleted the bau/update-pre-commit branch October 24, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants