Make config table optional #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertkol
force-pushed
the
make-config-table-optional
branch
2 times, most recently
from
3afbddc to
d9fe8f5
Compare
albertkol
force-pushed
the
make-config-table-optional
branch
from
1241dee to
03d9626
Compare
samuelhwilliams
previously approved these changes
Oct 3, 2024
albertkol
dismissed stale reviews from nuwan-samarasinghe and samuelhwilliams
via
58916c2
samuelhwilliams
approved these changes
Oct 4, 2024
samuelhwilliams
added a commit
to communitiesuk/funding-service-design-notification
that referenced
this pull request
Dec 24, 2024
This is to pull in the ability to disable the config table from communitiesuk/funding-service-design-utils#169. v6 added a breaking change, but it was reverted in 6.0.1 so nothing to do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
Allow for the Table config print to be optional.
Default behaviour prints the table, as before.
Set
FSD_UTILS_ENABLE_CONFIG_TABLEto "false". To turn it off.How to test
Not very easy..
FSD_UTILS_ENABLE_CONFIG_TABLE=falsein the docker runnerOr...
Take my word for it. 👍