Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config #165

Merged
merged 2 commits into from
Sep 20, 2024
Merged

config #165

merged 2 commits into from
Sep 20, 2024

Conversation

srh-sloan
Copy link
Collaborator

Config validation
Unit tests

@srh-sloan srh-sloan requested a review from gidsg September 20, 2024 12:28
gidsg
gidsg approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@gidsg gidsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 would prefer a negative list of envs to a positive one though if possible.

@suegarner suegarner merged commit 024fa53 into main Sep 20, 2024
3 checks passed
@suegarner suegarner deleted the fs-4647 branch September 20, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfount sfount sfount left review comments

@gidsg gidsg gidsg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@srh-sloan @gidsg @sfount @suegarner