Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BAU: remove unused filter #124

Merged
merged 5 commits into from
Feb 7, 2024
Merged

BAU: remove unused filter #124

merged 5 commits into from
Feb 7, 2024

Conversation

gidsg
Copy link
Contributor

@gidsg gidsg commented Feb 6, 2024

Change description

This filter was specific to Cloudfoundry so can be safely removed

  • Unit tests and other appropriate tests added or updated
  • README and other documentation has been updated / added (if needed)
  • Commit messages are meaningful and follow good commit message guidelines (e.g. "FS-XXXX: Add margin to nav items preventing overlapping of logo")

How to test

Should have no effect on current logging, as should not be able to hit this code path on AWS.

Screenshots of UI changes (if applicable)

srh-sloan
srh-sloan previously approved these changes Feb 6, 2024
Copy link
Contributor

@tferns tferns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one 👍

@gidsg gidsg merged commit 25a4978 into main Feb 7, 2024
6 checks passed
@gidsg gidsg deleted the bau-remove-unusued branch February 7, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants