Skip to content
This repository has been archived by the owner on Jul 25, 2024. It is now read-only.

SMD-536 add new PF auth class #137

Merged
merged 5 commits into from
Feb 26, 2024

Conversation

bobbi-hbrown
Copy link
Contributor

@bobbi-hbrown bobbi-hbrown commented Feb 20, 2024

https://dluhcdigital.atlassian.net/jira/software/c/projects/SMD/boards/140?quickFilter=815&selectedIssue=SMD-536

The Pathfinders role can now be set by an env variable in development, and should display the correct UI for Pathfinders.

Change description

  • Unit tests and other appropriate tests added or updated
  • README and other documentation has been updated / added (if needed)
  • Commit messages are meaningful and follow good commit message guidelines (e.g. "FS-XXXX: Add margin to nav items preventing overlapping of logo")

How to test

If manual testing is needed, give suggested testing steps

Screenshots of UI changes (if applicable)

@bobbi-hbrown bobbi-hbrown changed the title add new PF auth class WIP add new PF auth class Feb 20, 2024
@bobbi-hbrown bobbi-hbrown marked this pull request as draft February 20, 2024 17:39
app/main/authorisation.py Outdated Show resolved Hide resolved
app/main/authorisation.py Outdated Show resolved Hide resolved
app/__init__.py Outdated Show resolved Hide resolved
app/const.py Outdated Show resolved Hide resolved
app/__init__.py Outdated Show resolved Hide resolved
@bobbi-hbrown bobbi-hbrown force-pushed the SMD-536/feature/pathfinders-onboarding branch from ee1491f to 52eb541 Compare February 21, 2024 17:02
@bobbi-hbrown bobbi-hbrown force-pushed the SMD-536/feature/pathfinders-onboarding branch from 52eb541 to dbfb2d8 Compare February 21, 2024 17:03
@bobbi-hbrown bobbi-hbrown marked this pull request as ready for review February 21, 2024 17:03
@bobbi-hbrown bobbi-hbrown changed the title WIP add new PF auth class SMD-536 add new PF auth class Feb 22, 2024
@bobbi-hbrown bobbi-hbrown force-pushed the SMD-536/feature/pathfinders-onboarding branch 2 times, most recently from 98c5e7b to 3ec57e7 Compare February 22, 2024 18:48
@bobbi-hbrown bobbi-hbrown force-pushed the SMD-536/feature/pathfinders-onboarding branch from 3ec57e7 to 67e027b Compare February 23, 2024 15:50
Copy link
Contributor

@cyrusdobbs cyrusdobbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on dev and looks to be working 👍 LGTM

@bobbi-hbrown bobbi-hbrown merged commit eb32b2a into main Feb 26, 2024
2 checks passed
@bobbi-hbrown bobbi-hbrown deleted the SMD-536/feature/pathfinders-onboarding branch February 26, 2024 13:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants