FS-3797 #161

robk-dluhc · 2023-11-29T17:05:05Z

Workflow changes following review.

Unit tests and other appropriate tests added or updated
README and other documentation has been updated / added (if needed)
Commit messages are meaningful and follow good commit message guidelines (e.g. "FS-XXXX: Add margin to nav items preventing overlapping of logo")

aaronwilliamsv1

LGTM

aaronwilliamsv1

LGTM v2

aaronwilliamsv1

LGTM v3.0

robk-dluhc added 2 commits November 29, 2023 16:32

FS-3797 Fix workflow following review

40deb6f

Matrix value missed

013097d

aaronwilliamsv1 previously approved these changes Nov 29, 2023

View reviewed changes

Fix test default

37ba679

robk-dluhc dismissed aaronwilliamsv1’s stale review via 37ba679 November 30, 2023 07:39

robk-dluhc temporarily deployed to Dev November 30, 2023 07:39 — with GitHub Actions Inactive

robk-dluhc temporarily deployed to Dev November 30, 2023 07:40 — with GitHub Actions Inactive

robk-dluhc temporarily deployed to dev November 30, 2023 07:41 — with GitHub Actions Inactive

robk-dluhc temporarily deployed to Dev November 30, 2023 07:51 — with GitHub Actions Inactive

Wrong matrix here too

9a94e33

robk-dluhc temporarily deployed to Dev November 30, 2023 08:05 — with GitHub Actions Inactive

robk-dluhc had a problem deploying to Dev November 30, 2023 08:06 — with GitHub Actions Failure

robk-dluhc temporarily deployed to dev November 30, 2023 08:06 — with GitHub Actions Inactive

robk-dluhc temporarily deployed to dev November 30, 2023 08:07 — with GitHub Actions Inactive

robk-dluhc temporarily deployed to dev November 30, 2023 08:16 — with GitHub Actions Inactive

robk-dluhc temporarily deployed to test November 30, 2023 08:22 — with GitHub Actions Inactive

robk-dluhc temporarily deployed to Dev November 30, 2023 08:34 — with GitHub Actions Inactive

Block concurrency on post-deploy testing

3083b4c

robk-dluhc temporarily deployed to Dev November 30, 2023 08:58 — with GitHub Actions Inactive

robk-dluhc temporarily deployed to dev November 30, 2023 08:59 — with GitHub Actions Inactive

robk-dluhc had a problem deploying to Dev November 30, 2023 08:59 — with GitHub Actions Failure

robk-dluhc temporarily deployed to dev November 30, 2023 09:00 — with GitHub Actions Inactive

robk-dluhc temporarily deployed to dev November 30, 2023 09:09 — with GitHub Actions Inactive

robk-dluhc temporarily deployed to test November 30, 2023 09:21 — with GitHub Actions Inactive

robk-dluhc temporarily deployed to Dev November 30, 2023 09:31 — with GitHub Actions Inactive

aaronwilliamsv1 previously approved these changes Nov 30, 2023

View reviewed changes

Sandbox erroneously left in

55e4c39

robk-dluhc dismissed aaronwilliamsv1’s stale review via 55e4c39 November 30, 2023 11:56

robk-dluhc temporarily deployed to Dev November 30, 2023 11:56 — with GitHub Actions Inactive

robk-dluhc temporarily deployed to dev November 30, 2023 11:57 — with GitHub Actions Inactive

robk-dluhc had a problem deploying to Dev November 30, 2023 11:57 — with GitHub Actions Failure

aaronwilliamsv1 approved these changes Nov 30, 2023

View reviewed changes

robk-dluhc temporarily deployed to Dev November 30, 2023 12:07 — with GitHub Actions Inactive

robk-dluhc temporarily deployed to test November 30, 2023 12:13 — with GitHub Actions Inactive

robk-dluhc merged commit a92dfcb into main Nov 30, 2023
22 of 23 checks passed

robk-dluhc deleted the FS-3797 branch November 30, 2023 12:21

robk-dluhc temporarily deployed to Dev November 30, 2023 12:23 — with GitHub Actions Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

FS-3797 #161

FS-3797 #161

robk-dluhc commented Nov 29, 2023

aaronwilliamsv1 left a comment

aaronwilliamsv1 left a comment

aaronwilliamsv1 left a comment

FS-3797 #161

FS-3797 #161

Conversation

robk-dluhc commented Nov 29, 2023

aaronwilliamsv1 left a comment

Choose a reason for hiding this comment

aaronwilliamsv1 left a comment

Choose a reason for hiding this comment

aaronwilliamsv1 left a comment

Choose a reason for hiding this comment