This repository has been archived by the owner on Oct 28, 2024. It is now read-only.
forked from XGovFormBuilder/digital-form-builder
-
Notifications
You must be signed in to change notification settings - Fork 1
FS-3629: Add shared answer display class #400
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
8c03f5e
to
f0b8001
Compare
eaf22e8
to
c0053ea
Compare
c0053ea
to
534b94b
Compare
Adam-W1
reviewed
Nov 29, 2023
Adam-W1
reviewed
Nov 29, 2023
For more details, documentation, and updates, visit the [GitHub repository](https://github.com/communitiesuk/digital-form-builder/) for this project. | ||
|
||
Feel free to contribute and extend this package with additional tools and functionalities as needed. | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lovely docs @tferns 👍
Adam-W1
reviewed
Nov 29, 2023
@property | ||
@abstractmethod | ||
def as_pdf(self): | ||
raise NotImplementedError |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great use of ABC
tferns
commented
Nov 29, 2023
adamdavies1
approved these changes
Dec 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
python
directory with python specific tools for our fork of the digital-form-builderREADME.md
related to thepython
dir (writing better version atm)AnswerDisplayer
abstract classNote: Some components need to handle back-wards compatibility to how the component used to render, i.e
MultiInputFieldDisplayer
has both a legacy and new way of displaying. Also - when some components are embedded in aMultiInputField
component, their structure they're saved as is different, so some also have a implementation specifically for that scenario, i.e. UkAddressField and MonthYearField.Package
Available on PyPi here: https://pypi.org/project/funding-service-design-digital-form-builder-tools/0.0.1/
When merging to main, if the version is bumped (it's bumped to
0.0.2
here) - it will update on PyPi.