fix yarn tests

communitiesuk · Jun 10, 2024 · aec8ef7 · aec8ef7
1 parent a3a8c63
commit aec8ef7
Show file tree

Hide file tree

Showing 7 changed files with 13 additions and 19 deletions.
diff --git a/runner/src/server/plugins/engine/pageControllers/PageControllerBase.ts b/runner/src/server/plugins/engine/pageControllers/PageControllerBase.ts
@@ -559,7 +559,7 @@ export class PageControllerBase {
 
       viewModel.backLink =
         state.callback?.returnUrl ?? progress[progress.length - 2];
-      if (state["metadata"]["has_eligibility"]) {
+      if (state["metadata"] && state["metadata"]["has_eligibility"]) {
         viewModel.backLinkText = UtilHelper.getBackLinkText(
           true,
           this.model.def?.metadata?.isWelsh

diff --git a/runner/test/cases/server/plugins/engine/NotifyViewModel.json b/runner/test/cases/server/plugins/engine/NotifyViewModel.json
@@ -1,5 +1,5 @@
 {
-  "metadata": {},
+  "metadata": { "has_eligibility": false },
   "startPage": "/first-page",
   "pages": [
     {
@@ -104,8 +104,7 @@
       "value": "aSection.caz==2"
     }
   ],
-  "fees": [
-  ],
+  "fees": [],
   "outputs": [
     {
       "name": "notify",
@@ -118,10 +117,7 @@
         "templateId": "some-template-id",
         "emailField": "aSection.emailAddress",
         "addReferencesToPersonalisation": true,
-        "personalisation": [
-          "aSection.name",
-          "nameIsJen"
-        ],
+        "personalisation": ["aSection.name", "nameIsJen"],
         "emailReplyToIdConfiguration": [
           {
             "emailReplyToId": "default-email-id"
@@ -135,6 +131,6 @@
     }
   ],
   "version": 2,
-  "payApiKey": {"test": "test_api_key", "production": "production_api_key"},
+  "payApiKey": { "test": "test_api_key", "production": "production_api_key" },
   "skipSummary": false
 }
diff --git a/runner/test/cases/server/plugins/engine/SaveViewModel.json b/runner/test/cases/server/plugins/engine/SaveViewModel.json
@@ -1,5 +1,5 @@
 {
-  "metadata": {},
+  "metadata": { "has_eligibility": false },
   "startPage": "/first-page",
   "pages": [
     {

diff --git a/runner/test/cases/server/plugins/engine/SummaryViewModel.json b/runner/test/cases/server/plugins/engine/SummaryViewModel.json
@@ -1,5 +1,5 @@
 {
-  "metadata": {},
+  "metadata": { "has_eligibility": false },
   "startPage": "/first-page",
   "pages": [
     {
@@ -103,10 +103,8 @@
       "title": "Named Section"
     }
   ],
-  "conditions": [
-  ],
-  "fees": [
-  ],
+  "conditions": [],
+  "fees": [],
   "outputs": [
     {
       "name": "webhook",
@@ -118,6 +116,6 @@
     }
   ],
   "version": 2,
-  "payApiKey": {"test": "test_api_key", "production": "production_api_key"},
+  "payApiKey": { "test": "test_api_key", "production": "production_api_key" },
   "skipSummary": false
 }
diff --git a/runner/test/cases/server/plugins/engine/WebhookModel.test.ts b/runner/test/cases/server/plugins/engine/WebhookModel.test.ts
@@ -143,7 +143,7 @@ suite("WebhookModel", () => {
       formModel
     );
     expect(parsed).to.equal({
-      metadata: {},
+      metadata: { has_eligibility: false },
       name: "My Service",
       questions: [
         {

diff --git a/runner/test/cases/server/plugins/engine/WelshSummaryViewModel.json b/runner/test/cases/server/plugins/engine/WelshSummaryViewModel.json
@@ -1,5 +1,5 @@
 {
-  "metadata": { "isWelsh": true },
+  "metadata": { "isWelsh": true, "has_eligibility": false },
   "startPage": "/first-page",
   "pages": [
     {

diff --git a/runner/test/cases/server/services/webhookService.test.ts b/runner/test/cases/server/services/webhookService.test.ts
@@ -30,7 +30,7 @@ suite("Server WebhookService Service", () => {
     const serverMock = { logger: loggerSpy };
     const webHookeService = new WebhookService(serverMock);
     const result = await webHookeService.postRequest("/url", {});
-    expect(result).to.equal("1234");
+    expect(result).to.equal({ reference: "1234" });
   });
 
   test("Webhook returns correct reference when payload is object", async () => {