Display change requests

[albertkol]

Display change requests on the pages that received change requests.

Description

Apply is adding an extra metadata, change_requests.

change_requests are structured as such:

{
    "component.name": [
        "message_1", 
        "message_2"
    ],
    "component_2.name": [
        "message_3",
    ],
}

These will be displayed in the notification banner, above the form.

The catch is, we only need to display the banner on the form pages that the component is placed.

That is why we loop through all components on the page, to find out if the component received feedback:

const component = this.pageDef.components.find(component => component.name === componentName);
if (component) {
    // Add an object to viewModel.changeRequests
    viewModel.changeRequests.push({
        title: component.title,
        messages: messages
    });
}

Since all components can receive feedback, all components considered a question, we should display the banner on all possible Form Runner pages. So perhaps PageControllerBase is the place to add this logic?

Screenshots

Now:

Before:

[ksp37-dluhc]

Nice!

[sfount]

TS looks reasonable to me, a few optional changes to the markup

[nuwan-samarasinghe]

@albertkol @samuelhwilliams @MarcUsher shall we have a discussion about the change ? So safer side I am blocking the merge better if we can have a call if this is an urgent one we can merge.

[albertkol]

To do:

• move logic to PageController
• make a partial from the HTML and use the partial in layout.html
• write unit test
• create jira ticket for e2e test

[samuelhwilliams]

create jira ticket for e2e test

or you could do it in the same pr because it's just a test for this feature 👀

[albertkol]

You offering to help out with it @samuelhwilliams ? 👀

[albertkol]

I am a bit unsure how to run e2e tests on local.

So for now we will stick to the unit tests only.

Rest of the feedback was addressed.

[nuwan-samarasinghe]

Changes are ok but e2e fails so we cannot merge these changes can you fix that @albertkol we should have a passing e2e branch before merge

[nuwan-samarasinghe]

LGTM

[nuwan-samarasinghe]

LGTM

[sonarqubecloud]

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud