Enable slack deployment notifications

This differs from the `notify_slack` setting, which is more like `alert_slack_on_failed_deployments`. I'll maybe rename this separately... Related: communitiesuk/funding-service-design-workflows#265
communitiesuk · Feb 4, 2025 · 576d053 · 576d053
1 parent 4c0a6ac
commit 576d053
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/.github/workflows/copilot_deploy.yml b/.github/workflows/copilot_deploy.yml
@@ -475,10 +475,12 @@ jobs:
       AWS_ACCOUNT: ${{ secrets.AWS_ACCOUNT }}
       SLACK_BOT_TOKEN: ${{ secrets.SLACK_BOT_TOKEN }}
       SLACK_NOTIFICATION_CHANNEL_ID: ${{ secrets.SLACK_NOTIFICATION_CHANNEL_ID }}
+      SLACK_DEPLOYMENTS_CHANNEL_ID: ${{ secrets.SLACK_DEPLOYMENTS_CHANNEL_ID }}
     with:
       environment: prod
       app_name: form-runner-adapter
       run_db_migrations: false
       image_location: ghcr.io/communitiesuk/funding-service-design-form-runner-adapter:sha-${{ github.sha }}
       notify_slack: true
+      notify_slack_on_deployment: true
 
diff --git a/designer/server/plugins/routes/PutFormWithIdRouteRegister.ts b/designer/server/plugins/routes/PutFormWithIdRouteRegister.ts
@@ -30,7 +30,7 @@ export const putFormWithIdRouteRegister: ServerRoute = {
                 await persistenceService.uploadConfiguration(
                     `${id}`,
                     JSON.stringify(value)
-                );
+                );e
                 await publish(id, value);
                 return h.response({ok: true}).code(204);
             } catch (err) {

diff --git a/runner/src/server/plugins/engine/api/RegisterFormPublishApi.ts b/runner/src/server/plugins/engine/api/RegisterFormPublishApi.ts
@@ -39,7 +39,7 @@ export class RegisterFormPublishApi implements RegisterApi {
                 if (!previewMode || previewMode==="false") {
                     request.logger.error(
                         [`POST /publish`, "previewModeError"],
-                        disabledRouteDetailString
+                        disabledRouteDetailStringe
                     );
                     throw Boom.forbidden("Publishing is disabled");
                 }