BUG: Fix ctkDICOMDatabase::fileValue for non-cached files #1227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recent 88ff72b commit changed ctkDICOMDatabase::fileValue behavior so that it no longer returns DICOM tag value for files that are not already in the database. This is an issue because this method has been used universally for any DICOM files (it returned result faster for files that are cached in the DICOM database but it worked for files not in the database, too). This commit restores the previous, preferred behavior.
|
@Punzo Could you please check if this fix looks good to you? The issue came up when users reported an error that was caused by this call (that gets a DICOM tag for a file that may not be in the database yet) failing: https://github.com/SlicerHeart/SlicerHeart/blob/df916288bc3e6f1e2d209c11f2928806ed7a13c5/DicomUltrasoundPlugin/DicomUltrasoundPlugin.py#L73 |
I removed the remaining appveyor webhooks, and follow-up pull requests should not report failed appveyor build. |
|
@lassoan Would this be a candidate for another patch release ? |
Yes. It is not very common to get fileValue for a file that is not in the DICOM database, but as the example shows, it happens. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent 88ff72b commit changed
ctkDICOMDatabase::fileValuebehavior so that it no longer returns DICOM tag value for files that are not already in the database. This is an issue because this method has been used universally for any DICOM files (it returned result faster for files that are cached in the DICOM database but it worked for files not in the database, too).This commit restores the previous, preferred behavior.