RESTEasy bootstrap agreement, 2025-04-07 #252
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhusar
suggested changes
Apr 7, 2025
rhusar
reviewed
Apr 7, 2025
| @@ -68,6 +69,8 @@ The Commonhaus Foundation uses the following unregistered trademarks: | |||
| <img src="https://github.com/easymock/objenesis/blob/master/website/site/resources/objenesis-logo.png?raw=true" alt="" height="30" /> | |||
| - Quarkus Logo ™ [^1] | |||
| <img src="https://github.com/quarkusio/quarkus/blob/main/core/deployment/src/main/resources/META-INF/branding/logo.png?raw=true" alt="" height="30" /> | |||
| - RESTEasy Logo ™ [^1] | |||
| <img src="https://github.com/resteasy/resteasy.dev/blob/main/img/logo/resteasy_logo_600x.png?raw=true" alt="" height="30" /> | |||
There was a problem hiding this comment.
Nitpick:
s/alt=""/alt="RESTEasy logo"
This is not a decorative image so it should have a proper alt description.
There was a problem hiding this comment.
That would make this the outlier from all the others which have alt="".
There was a problem hiding this comment.
A correct outlier that is :-) It's definitely not the scope of this PR to fix this for others.
There was a problem hiding this comment.
I felt that putting the wordmark version of the logo in as the alt tag is redundant. This img is in a logo section. The Word mark / project name precedes it. Wordmark is also already listed in the section above. If I were to go back and modify them, the alt text would more likely uniformly say "logo"
Signed-off-by: James R. Perkins <jperkins@redhat.com>
jamezp
force-pushed
the
resteasy-bootstrap
branch
from
a6a294b to
7969f72
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#251