-
Notifications
You must be signed in to change notification settings - Fork 26
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Only update react-select child component types where necessary when u…
…sing `moduleResolution: bundler` tsconfig setting (#3056) * fix: compat with emotion v11.14 * docs: refine changeset * chore(react-select): only typecast types when necessary for react-select child components * fix: refine types * docs: changeset * docs: remove duplicate changeset * chore(changeset): add changeset --------- Co-authored-by: Nicola Molinari <nicola.molinari@commercetools.com>
- Loading branch information
1 parent
a5a009d
commit e717a65
Showing
6 changed files
with
122 additions
and
393 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
--- | ||
'@commercetools-uikit/async-creatable-select-input': patch | ||
'@commercetools-uikit/creatable-select-input': patch | ||
'@commercetools-uikit/async-select-input': patch | ||
'@commercetools-uikit/select-input': patch | ||
--- | ||
|
||
We are now using `moduleResolution: bundler` which attempts to optimize to avoid long paths. The re-exported components from `react-select` need to be explicitly typed now, to avoid TypeScript having to infer an internal import path. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
--- | ||
'@commercetools-uikit/async-creatable-select-input': patch | ||
'@commercetools-uikit/creatable-select-input': patch | ||
'@commercetools-uikit/async-select-input': patch | ||
'@commercetools-uikit/flat-button': patch | ||
'@commercetools-uikit/select-input': patch | ||
--- | ||
|
||
Remove type annotations from re-exported react-select child components where they are not necessary to reduce verbosity and maintain type consistency |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.