Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEVX-322] QueryAll allows different field than id to be used #837

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

jenschude
Copy link
Contributor

@jenschude jenschude commented Feb 24, 2025

  • Changeset added

Features

Closes #341

Fixes

Breaking changes

@jenschude jenschude requested a review from a team as a code owner February 24, 2025 13:42
@jenschude jenschude changed the title QueryAll allows different field than id to be used [DEVX-322] QueryAll allows different field than id to be used Feb 24, 2025
Copy link

codecov bot commented Feb 24, 2025

Codecov Report

Attention: Patch coverage is 56.00000% with 11 lines in your changes missing coverage. Please review.

Project coverage is 10.08%. Comparing base (88f5536) to head (f7c3ae9).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
.../java/com/commercetools/api/client/QueryUtils.java 50.00% 6 Missing ⚠️
...in/java/com/commercetools/api/client/QueryAll.java 61.53% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #837      +/-   ##
============================================
+ Coverage     10.06%   10.08%   +0.01%     
- Complexity     1956     1957       +1     
============================================
  Files          6896     6896              
  Lines         67282    67301      +19     
  Branches        288      289       +1     
============================================
+ Hits           6774     6785      +11     
- Misses        60331    60339       +8     
  Partials        177      177              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenschude jenschude merged commit 21dba51 into main Feb 25, 2025
12 checks passed
@jenschude jenschude deleted the query_all_improvement branch February 25, 2025 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QueryAll with sort order other than by id returns duplicate and incomplete search results.
1 participant