Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deserialization of time attributes/custom-fields #818

Merged
merged 3 commits into from
Feb 4, 2025

Conversation

jenschude
Copy link
Contributor

Increased the number of fractional seconds to match for DateTime attributes and custom fields

  • Changeset added

Features

Fixes

Breaking changes

Increased the number of fractional seconds to match for DateTime attributes and custom fields
@jenschude jenschude requested a review from a team as a code owner February 3, 2025 12:39
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.07%. Comparing base (ccf877f) to head (29851e7).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #818   +/-   ##
=========================================
  Coverage     10.07%   10.07%           
  Complexity     1956     1956           
=========================================
  Files          6895     6895           
  Lines         67239    67239           
  Branches        282      282           
=========================================
  Hits           6774     6774           
  Misses        60290    60290           
  Partials        175      175           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@lojzatran lojzatran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

btw why is it 10 and not 9 or 11?

@jenschude
Copy link
Contributor Author

jenschude commented Feb 4, 2025

👍

btw why is it 10 and not 9 or 11?

First wanted to be sure to capture all. But looking it up, the maximum value for DateTime.getNanos is obviously 999.999.999 so 9 is sufficient

@kodiakhq kodiakhq bot merged commit 51aa295 into main Feb 4, 2025
13 checks passed
@kodiakhq kodiakhq bot deleted the attribute-time-deserialize-fix branch February 4, 2025 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants