Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search builder #542

Merged
merged 10 commits into from
Jan 23, 2024
Merged

Search builder #542

merged 10 commits into from
Jan 23, 2024

Conversation

jenschude
Copy link
Contributor

  • Changeset added

Features

Fixes

Breaking changes

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

Attention: 153 lines in your changes are missing coverage. Please review.

Comparison is base (7c20076) 10.18% compared to head (a5f0481) 10.83%.

Files Patch % Lines
...search/products/ProductFacetExpressionBuilder.java 55.55% 28 Missing ⚠️
...ools/api/search/products/RangeFacetExpression.java 66.66% 17 Missing ⚠️
...tools/api/search/products/ContainerExpression.java 55.55% 11 Missing and 1 partial ⚠️
...i/search/products/CategoryTermFacetExpression.java 65.51% 10 Missing ⚠️
.../search/products/CategoryTermFilterExpression.java 65.51% 10 Missing ⚠️
...tools/api/search/products/TermFacetExpression.java 78.72% 9 Missing and 1 partial ⚠️
...ch/products/ReferenceableTermFilterExpression.java 55.00% 9 Missing ⚠️
...mercetools/api/search/products/PathExpression.java 60.00% 8 Missing ⚠️
...earch/products/ProductFilterExpressionBuilder.java 92.98% 8 Missing ⚠️
...ools/api/search/products/TermFilterExpression.java 75.00% 8 Missing ⚠️
... and 10 more
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #542      +/-   ##
============================================
+ Coverage     10.18%   10.83%   +0.64%     
- Complexity     1680     1837     +157     
============================================
  Files          5966     5989      +23     
  Lines         56478    57053     +575     
  Branches        261      261              
============================================
+ Hits           5752     6179     +427     
- Misses        50563    50709     +146     
- Partials        163      165       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenschude jenschude marked this pull request as ready for review January 23, 2024 10:38
@jenschude jenschude merged commit 154b530 into main Jan 23, 2024
9 checks passed
@jenschude jenschude deleted the search-builder branch January 23, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant