chore: rename all reducers actions and payload variables

commercelayer · Mar 21, 2023 · ca5b897 · ca5b897
1 parent 98857a9
commit ca5b897
Show file tree

Hide file tree

Showing 10 changed files with 41 additions and 34 deletions.
diff --git a/packages/app-webhooks/src/components/Delete/Provider.tsx b/packages/app-webhooks/src/components/Delete/Provider.tsx
@@ -30,10 +30,10 @@ export function WebhookDeleteProvider({
 
   const fetchWebhook = useCallback(async () => {
     try {
-      const webhookDelete = await sdkClient.webhooks.retrieve(webhookId)
-      dispatch({ type: 'loadData', payload: webhookDelete })
+      const webhook = await sdkClient.webhooks.retrieve(webhookId)
+      dispatch({ type: 'webhook/loaded', payload: webhook })
     } catch {
-      dispatch({ type: 'setNotFound' })
+      dispatch({ type: 'webhook/onError' })
     }
   }, [webhookId])
 

diff --git a/packages/app-webhooks/src/components/Delete/reducer.ts b/packages/app-webhooks/src/components/Delete/reducer.ts
@@ -1,20 +1,22 @@
 import { Webhook } from '@commercelayer/sdk'
 import { WebhookDeleteContextState } from 'App'
 
-type Action = { type: 'loadData'; payload: Webhook } | { type: 'setNotFound' }
+type Action =
+  | { type: 'webhook/loaded'; payload: Webhook }
+  | { type: 'webhook/onError' }
 
 export const reducer = (
   state: WebhookDeleteContextState,
   action: Action
 ): WebhookDeleteContextState | never => {
   switch (action.type) {
-    case 'loadData':
+    case 'webhook/loaded':
       return {
         ...state,
         data: action.payload,
         isLoading: false
       }
-    case 'setNotFound':
+    case 'webhook/onError':
       return {
         ...state,
         isNotFound: true,

diff --git a/packages/app-webhooks/src/components/Details/Provider.tsx b/packages/app-webhooks/src/components/Details/Provider.tsx
@@ -33,9 +33,9 @@ export function WebhookDetailsProvider({
       const webhook = await sdkClient.webhooks.retrieve(webhookId, {
         include: ['last_event_callbacks']
       })
-      dispatch({ type: 'loadData', payload: webhook })
+      dispatch({ type: 'webhook/loaded', payload: webhook })
     } catch {
-      dispatch({ type: 'setNotFound' })
+      dispatch({ type: 'webhook/onError' })
     }
   }, [webhookId])
 
@@ -48,7 +48,7 @@ export function WebhookDetailsProvider({
         }
       )
       .then((webhook) => {
-        dispatch({ type: 'loadData', payload: webhook })
+        dispatch({ type: 'webhook/loaded', payload: webhook })
       })
       .catch(() => {})
   }, [webhookId])

diff --git a/packages/app-webhooks/src/components/Details/reducer.ts b/packages/app-webhooks/src/components/Details/reducer.ts
@@ -1,20 +1,22 @@
 import { Webhook } from '@commercelayer/sdk'
 import { WebhookDetailsContextState } from 'App'
 
-type Action = { type: 'loadData'; payload: Webhook } | { type: 'setNotFound' }
+type Action =
+  | { type: 'webhook/loaded'; payload: Webhook }
+  | { type: 'webhook/onError' }
 
 export const reducer = (
   state: WebhookDetailsContextState,
   action: Action
 ): WebhookDetailsContextState | never => {
   switch (action.type) {
-    case 'loadData':
+    case 'webhook/loaded':
       return {
         ...state,
         data: action.payload,
         isLoading: false
       }
-    case 'setNotFound':
+    case 'webhook/onError':
       return {
         ...state,
         isNotFound: true,

diff --git a/packages/app-webhooks/src/components/EventCallbacks/Provider.tsx b/packages/app-webhooks/src/components/EventCallbacks/Provider.tsx
@@ -37,7 +37,8 @@ export function ListEventCallbackProvider({
   const [state, dispatch] = useReducer(reducer, initialState)
 
   const changePage = useCallback(
-    (page: number) => dispatch({ type: 'changePage', payload: page }),
+    (page: number) =>
+      dispatch({ type: 'eventCallbacks/changePage', payload: page }),
     []
   )
 
@@ -49,7 +50,7 @@ export function ListEventCallbackProvider({
         webhookId,
         pageSize
       })
-      dispatch({ type: 'loadData', payload: eventCallbacks })
+      dispatch({ type: 'eventCallbacks/loaded', payload: eventCallbacks })
     }
   }, [webhookId, state.currentPage])
 

diff --git a/packages/app-webhooks/src/components/EventCallbacks/reducer.ts b/packages/app-webhooks/src/components/EventCallbacks/reducer.ts
@@ -3,28 +3,28 @@ import { ListResponse } from '@commercelayer/sdk/lib/cjs/resource'
 import { ListEventCallbackContextState } from 'App'
 
 type Action =
-  | { type: 'loadData'; payload: ListResponse<EventCallback> }
-  | { type: 'changePage'; payload: number }
-  | { type: 'sort'; payload: 'asc' | 'desc' }
+  | { type: 'eventCallbacks/loaded'; payload: ListResponse<EventCallback> }
+  | { type: 'eventCallbacks/changePage'; payload: number }
+  | { type: 'eventCallbacks/changeSort'; payload: 'asc' | 'desc' }
 
 export const reducer = (
   state: ListEventCallbackContextState,
   action: Action
 ): ListEventCallbackContextState => {
   switch (action.type) {
-    case 'loadData':
+    case 'eventCallbacks/loaded':
       return {
         ...state,
         list: action.payload,
         isLoading: false
       }
-    case 'changePage':
+    case 'eventCallbacks/changePage':
       return {
         ...state,
         currentPage: action.payload,
         isLoading: true
       }
-    case 'sort':
+    case 'eventCallbacks/changeSort':
       return {
         ...state,
         sort: {

diff --git a/packages/app-webhooks/src/components/Form/Provider.tsx b/packages/app-webhooks/src/components/Form/Provider.tsx
@@ -30,10 +30,10 @@ export function WebhookFormProvider({
 
   const fetchJob = useCallback(async () => {
     try {
-      const webhookForm = await sdkClient.webhooks.retrieve(webhookId)
-      dispatch({ type: 'loadData', payload: webhookForm })
+      const webhook = await sdkClient.webhooks.retrieve(webhookId)
+      dispatch({ type: 'webhook/loaded', payload: webhook })
     } catch {
-      dispatch({ type: 'setNotFound' })
+      dispatch({ type: 'webhook/onError' })
     }
   }, [webhookId])
 

diff --git a/packages/app-webhooks/src/components/Form/reducer.ts b/packages/app-webhooks/src/components/Form/reducer.ts
@@ -1,20 +1,22 @@
 import { Webhook } from '@commercelayer/sdk'
 import { WebhookFormContextState } from 'App'
 
-type Action = { type: 'setNotFound' } | { type: 'loadData'; payload: Webhook }
+type Action =
+  | { type: 'webhook/onError' }
+  | { type: 'webhook/loaded'; payload: Webhook }
 
 export const reducer = (
   state: WebhookFormContextState,
   action: Action
 ): WebhookFormContextState | never => {
   switch (action.type) {
-    case 'setNotFound':
+    case 'webhook/onError':
       return {
         ...state,
         isNotFound: true,
         isLoading: false
       }
-    case 'loadData':
+    case 'webhook/loaded':
       return {
         ...state,
         data: action.payload,

diff --git a/packages/app-webhooks/src/components/List/Provider.tsx b/packages/app-webhooks/src/components/List/Provider.tsx
@@ -31,7 +31,7 @@ export function ListWebhookProvider({
   const [state, dispatch] = useReducer(reducer, initialState)
 
   const changePage = useCallback(
-    (page: number) => dispatch({ type: 'changePage', payload: page }),
+    (page: number) => dispatch({ type: 'webhooks/changePage', payload: page }),
     []
   )
 
@@ -41,7 +41,7 @@ export function ListWebhookProvider({
       state,
       pageSize
     })
-    dispatch({ type: 'loadData', payload: webhooks })
+    dispatch({ type: 'webhooks/loaded', payload: webhooks })
   }, [state.currentPage])
 
   useEffect(

diff --git a/packages/app-webhooks/src/components/List/reducer.ts b/packages/app-webhooks/src/components/List/reducer.ts
@@ -3,28 +3,28 @@ import { ListResponse } from '@commercelayer/sdk/lib/cjs/resource'
 import { ListWebhookContextState } from 'App'
 
 type Action =
-  | { type: 'loadData'; payload: ListResponse<Webhook> }
-  | { type: 'changePage'; payload: number }
-  | { type: 'sort'; payload: 'asc' | 'desc' }
+  | { type: 'webhooks/loaded'; payload: ListResponse<Webhook> }
+  | { type: 'webhooks/changePage'; payload: number }
+  | { type: 'webhooks/changeSort'; payload: 'asc' | 'desc' }
 
 export const reducer = (
   state: ListWebhookContextState,
   action: Action
 ): ListWebhookContextState => {
   switch (action.type) {
-    case 'loadData':
+    case 'webhooks/loaded':
       return {
         ...state,
         list: action.payload,
         isLoading: false
       }
-    case 'changePage':
+    case 'webhooks/changePage':
       return {
         ...state,
         currentPage: action.payload,
         isLoading: true
       }
-    case 'sort':
+    case 'webhooks/changeSort':
       return {
         ...state,
         sort: {