Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Advanced config to remove autofocus on firt input #439

Merged
merged 4 commits into from
Dec 10, 2024
Merged

Conversation

yurj
Copy link
Contributor

@yurj yurj commented Dec 9, 2024

Add a checkbox to disable autofocus on the first input. It is enabled by default as is the default in Dexterity forms so it should not break anything.

@yurj yurj requested a review from ale-rt December 9, 2024 12:24
Copy link
Member

@ale-rt ale-rt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not using this package in these days, but the PR LGTM.

I see the autofocus field defaults to True, but this should not change anyones experience, given that:

https://github.com/plone/plone.app.z3cform/blob/ec706f171b684328c06423b49bf4fe37924c5961/plone/app/z3cform/templates/macros.pt#L88

P.s.: before merging, please add a changelog line.

Thanks for your contribution

@mauritsvanrees
Copy link
Member

Seems fine. But both with and without this PR I don't see autofocus working. At least not in Firefox.

@yurj
Copy link
Contributor Author

yurj commented Dec 10, 2024

@mauritsvanrees you should see the pat-formautofocus class, the pattern depends on it. I've seen it working in FF but if it doesn't work in some cases, it should be a mockup issue.

@ale-rt I will add a changelog

@yurj yurj merged commit 4bbeeeb into master Dec 10, 2024
4 checks passed
@yurj yurj deleted the yurj_autofocus branch December 10, 2024 22:20
@mauritsvanrees
Copy link
Member

I have released collective.easyform 4.3.0 with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants