Skip to content

Commit

Permalink
Moved the websocket to /ros-bridge to avoid a conflict with the redir
Browse files Browse the repository at this point in the history
  • Loading branch information
jpc committed Apr 14, 2022
1 parent 9eabe35 commit cf5eb36
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 7 deletions.
6 changes: 1 addition & 5 deletions Caddyfile
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,7 @@ handle_path /foxglove {

redir / /notebooks/notebooks/CARLA%20πŸ’œ%20Foxglove%20demo.ipynb

@ws {
header Connection *Upgrade*
header Upgrade websocket
}
reverse_proxy @ws ros-bridge:9090 {
reverse_proxy /ros-bridge ros-bridge:9090 {
header_up Host localhost:9090
}

Expand Down
4 changes: 2 additions & 2 deletions notebooks/CARLA πŸ’œ Foxglove demo.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@
" setTimeout(code_toggle, 0);\n",
"</script>\n",
"<button class=\"button-63\" onclick=\"restart_run_all()\">A. Setup the ego-vehicle</button><br />\n",
"<a class=\"button-63\" href=\"/foxglove?ds=rosbridge-websocket&ds.url=ws%3A%2F%2Flocalhost%3A8080&layoutURL=foxglove_layout.json\" target=\"_blank\">B. Open Foxglove Studio</a><br />\n",
"<a class=\"button-63\" href=\"/foxglove?ds=rosbridge-websocket&ds.url=ws%3A%2F%2Flocalhost%3A8080%2Fros-bridge&layoutURL=foxglove_layout.json\" target=\"_blank\">B. Open Foxglove Studio</a><br />\n",
"<button class=\"button-63\" onclick=\"code_toggle()\">C. Explore the source code</button><br />\n"
],
"text/plain": [
Expand Down Expand Up @@ -162,7 +162,7 @@
" setTimeout(code_toggle, 0);\n",
"</script>\n",
"<button class=\"button-63\" onclick=\"restart_run_all()\">A. Setup the ego-vehicle</button><br />\n",
"<a class=\"button-63\" href=\"/foxglove?ds=rosbridge-websocket&ds.url=ws%3A%2F%2Flocalhost%3A8080&layoutURL=foxglove_layout.json\" target=\"_blank\">B. Open Foxglove Studio</a><br />\n",
"<a class=\"button-63\" href=\"/foxglove?ds=rosbridge-websocket&ds.url=ws%3A%2F%2Flocalhost%3A8080%2Fros-bridge&layoutURL=foxglove_layout.json\" target=\"_blank\">B. Open Foxglove Studio</a><br />\n",
"<button class=\"button-63\" onclick=\"code_toggle()\">C. Explore the source code</button><br />\n",
"'''))"
]
Expand Down

0 comments on commit cf5eb36

Please sign in to comment.