Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh payment block on selecting Pay later #937

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

jitendrapurohit
Copy link
Collaborator

Overview

Refresh payment block on selecting pay later.

Before

Payment block is not refreshed if user selects pay later. This causes an issue when Stripe is a default payment option selected on the webform. To replicate:

  • Create a webform with Contritbuion section enabled.
  • Ensure Payment processor is set to "User Select" with Stripe & pay later as options. Default = Stripe.
  • Load the webform, and notice stripe is selected by default.
  • Select pay later and submit.
  • The webform redirects to front page and no submission is recorded.

After

Fixed.

Technical Details

Js seems to avoid refreshing the payment block if pay later is selected. This PR removes that condition.

@jitendrapurohit
Copy link
Collaborator Author

@mattwire Would you be interested to test/merge this please?

@CsarRamos
Copy link

@mattwire Would you be interested to test/merge this please?

I just had this error and the patch fixed it, thank you.

@jitendrapurohit
Copy link
Collaborator Author

Thanks for reviewing @CsarRamos

@KarinG KarinG merged commit fe718c9 into colemanw:6.x Jun 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants