Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix E_WARNING and add check for no red error boxes #1043

Open
wants to merge 3 commits into
base: 6.x
Choose a base branch
from

Conversation

demeritcowboy
Copy link
Collaborator

Overview

@demeritcowboy
Copy link
Collaborator Author

demeritcowboy commented Feb 20, 2025

Yes now it fails but in the right place as it always should have:

1) Drupal\Tests\webform_civicrm\FunctionalJavascript\CustomFieldSubmissionTest::testDynamicCustomFields
Error message Warning: Undefined array key "name" in Drupal\webform_civicrm\AdminForm::insertComponent() (line 2275 of /home/runner/work/webform_civicrm/webform_civicrm/src/AdminForm.php). Deprecated function: str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated in Drupal\webform_civicrm\AdminForm::insertComponent() (line 2275 of /home/runner/work/webform_civicrm/webform_civicrm/src/AdminForm.php). Close message
Failed asserting that actual size 1 matches expected size 0.

/home/runner/drupal/vendor/phpunit/phpunit/src/Framework/Constraint/Constraint.php:122
/home/runner/drupal/vendor/phpunit/phpunit/src/Framework/Constraint/Constraint.php:56
/home/runner/work/webform_civicrm/webform_civicrm/tests/src/FunctionalJavascript/WebformCivicrmTestBase.php:292
/home/runner/work/webform_civicrm/webform_civicrm/tests/src/FunctionalJavascript/CustomFieldSubmissionTest.php:353

@demeritcowboy demeritcowboy changed the title try to make this test fail again now that it doesn't Fix E_WARNING and add check for no red error boxes Feb 20, 2025
@demeritcowboy
Copy link
Collaborator Author

That fixes the E_WARNING, so now putting full workflow back.

@demeritcowboy
Copy link
Collaborator Author

Oh right. 5.82.1 hasn't been released yet. Hence the 5.82 fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant