feat: Native Send Component #1874
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
brendan-defi
force-pushed
the
bf/ock-send
branch
from
bf2eb1f to
bb6562d
Compare
brendan-defi
force-pushed
the
bf/ock-send
branch
from
342bbfb to
95ee15c
Compare
brendan-defi
force-pushed
the
bf/ock-send
branch
from
95ee15c to
43a0f8a
Compare
dschlabach
reviewed
Mar 4, 2025
Comment on lines
+156
to
+160
| onKeyDown={(e) => { | ||
| if (e.key === 'Enter' || e.key === ' ') { | ||
| onActionPress?.(); | ||
| } | ||
| }} |
There was a problem hiding this comment.
I'm a little confused why you need an explicit onKeyDown handler? Shouldn't <button /> handle that out of the box?
There was a problem hiding this comment.
yes, you're right, removing in 2068
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Notes to reviewers
How has it been tested?