fix: getPriceQuote error message and types (#2073)

coinbase · Mar 4, 2025 · 68bc0a8 · 68bc0a8
1 parent bded965
commit 68bc0a8
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/src/api/getPriceQuote.test.ts b/src/api/getPriceQuote.test.ts
@@ -67,7 +67,7 @@ describe('getPriceQuote', () => {
     expect(result).toEqual({
       code: 'INVALID_INPUT',
       error: 'Invalid input: tokens must be an array of at least one token',
-      message: '',
+      message: 'Tokens must be an array of at least one token',
     });
   });
 

diff --git a/src/api/getPriceQuote.ts b/src/api/getPriceQuote.ts
@@ -29,7 +29,7 @@ export async function getPriceQuote(
     );
     if (res.error) {
       return {
-        code: `${res.error.code}`,
+        code: String(res.error.code),
         error: 'Error fetching price quote',
         message: res.error.message,
       };
@@ -51,7 +51,7 @@ function validateGetPriceQuoteParams(params: GetPriceQuoteParams) {
     return {
       code: 'INVALID_INPUT',
       error: 'Invalid input: tokens must be an array of at least one token',
-      message: '',
+      message: 'Tokens must be an array of at least one token',
     };
   }
 

diff --git a/src/api/types.ts b/src/api/types.ts
@@ -397,15 +397,15 @@ export type GetPriceQuoteParams = {
 
 type PriceQuote = {
   /** The name of the token */
-  name: string | '';
+  name: string;
   /** The symbol of the token */
-  symbol: string | '';
+  symbol: string;
   /** The contract address of the token */
   contractAddress: Address | '';
   /** The price of the token */
-  price: string | '';
+  price: string;
   /** The timestamp of the price quote */
-  timestamp: number | 0;
+  timestamp: number;
 };
 
 /**