Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: improving floating point math accuracy while dealing with atomic amounts #54

Merged
merged 1 commit into from
Feb 28, 2025
Merged

chore: improving floating point math accuracy while dealing with atomic amounts #54

merged 1 commit into from
Feb 28, 2025

Conversation

drohit-cb
Copy link
Contributor

What changed? Why?

This PR helps:

  1. Improve floating point math accuracy while dealing with atomic amounts.
  2. Adds unit tests around it
  3. Similar to FromAtomicAmount exposes toAtomicAmount as well to be consistent.

Qualified Impact

@cb-heimdall
Copy link

cb-heimdall commented Feb 28, 2025 •
edited
Loading

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@drohit-cb drohit-cb requested a review from djoyahoy February 28, 2025 16:55
@drohit-cb drohit-cb marked this pull request as ready for review February 28, 2025 16:55
@drohit-cb drohit-cb merged commit 8d4e502 into master Feb 28, 2025
5 checks passed
@drohit-cb drohit-cb deleted the chore/improve-floating-point-precision branch February 28, 2025 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djoyahoy djoyahoy djoyahoy approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drohit-cb @cb-heimdall @djoyahoy