Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose withdrawal credentials of ethereum validators #53

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

drohit-cb
Copy link
Contributor

@drohit-cb drohit-cb commented Feb 27, 2025

What changed? Why?

This PR helps expose withdrawal credentials of ethereum validators in preparation of Pectra. Using this customers can tell if their validator is a 0x01 or a 0x02 validator.

testing

Example local run

2025/02/27 11:22:14 0x010000000000000000000000db816889f2a7362ef242e5a717dfd5b38ae849fe 0xdb816889f2a7362ef242e5a717dfd5b38ae849fe, 0x971d618c9d38c9a189c9b5d2514e1b2f7191992ff3ad14f766a331685b11ef19734d1cdcac65349f44caa218bfa4a85e, active
2025/02/27 11:22:14 0x010000000000000000000000db816889f2a7362ef242e5a717dfd5b38ae849fe 0xdb816889f2a7362ef242e5a717dfd5b38ae849fe, 0xb25c46bdbd8e9ac5afdee4e454f6ce57a0e5a26b705a280b600e2aa8a4c238fcc3522798ce6b49cfd45ed80007aefe0c, active
2025/02/27 11:22:14 0x010000000000000000000000db816889f2a7362ef242e5a717dfd5b38ae849fe 0xdb816889f2a7362ef242e5a717dfd5b38ae849fe, 0xa1abe4d3b8557c1ec0076591549f14fefc27d313c9dc44f7da4232a41156b84c92fff0403c68fdaf95a1ef23d1511e3a, active
2025/02/27 11:22:14 0x010000000000000000000000db816889f2a7362ef242e5a717dfd5b38ae849fe 0xdb816889f2a7362ef242e5a717dfd5b38ae849fe, 0xaf8abb7eb2cfd2c34280016cff4005b6c4159807da8cf1fad1921c84b220af5fa9cfd43bdaf470fe4384c79d37a09eed, active
2025/02/27 11:22:14 0x010000000000000000000000db816889f2a7362ef242e5a717dfd5b38ae849fe 0xdb816889f2a7362ef242e5a717dfd5b38ae849fe, 0x85cec05d59b45f53b5e30137bd2cc39a68c9a3eda6a814307df7d00719d130e227ab00e535836937c53747a9f6881982, active
2025/02/27 11:22:14 0x010000000000000000000000db816889f2a7362ef242e5a717dfd5b38ae849fe 0xdb816889f2a7362ef242e5a717dfd5b38ae849fe, 0xa5d9c1d1d7b601cfb1e62970260bc37c1a19534867b84f9539f783dfd94971880f180819432c52648f68e5c9df29ea85, active

Qualified Impact

@cb-heimdall
Copy link

cb-heimdall commented Feb 27, 2025

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@drohit-cb drohit-cb requested a review from djoyahoy February 27, 2025 19:26
@drohit-cb drohit-cb marked this pull request as ready for review February 27, 2025 19:29
@drohit-cb drohit-cb merged commit 1825c32 into master Feb 27, 2025
5 checks passed
@drohit-cb drohit-cb deleted the expose-withdrawal-creds-list-validators-api branch February 27, 2025 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants