Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose pending claimable balance #51

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

drohit-cb
Copy link
Contributor

@drohit-cb drohit-cb commented Feb 10, 2025

What changed? Why?

This PR helps expose the pending_claimable_balance at SDK level that was being returned from the backend starting this PR #48

Testing

Example show stakeable, unstakeable and pending claimable balances of a wallet.

>> go run examples/ethereum/shared-eth-stake/main.go /Users/rohit/code/cb/staking/.coinbase_cloud_api_key_production.json 0x87Bf57c3d7B211a100ee4d00dee08435130A62fA
2025/02/10 15:24:13 stakeable balance: Balance { amount: '3.254773242' asset: 'Asset { networkId: 'ethereum-holesky' assetId: 'eth' contractAddress: '' decimals: '18' }' }
2025/02/10 15:24:13 unstakeableBalance balance: Balance { amount: '0.2119132771' asset: 'Asset { networkId: 'ethereum-holesky' assetId: 'eth' contractAddress: '' decimals: '18' }' }
2025/02/10 15:24:13 pending claimable balance: Balance { amount: '9.8e-17' asset: 'Asset { networkId: 'ethereum-holesky' assetId: 'eth' contractAddress: '' decimals: '18' }' }

Qualified Impact

@cb-heimdall
Copy link

cb-heimdall commented Feb 10, 2025

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@drohit-cb drohit-cb marked this pull request as ready for review February 10, 2025 23:29
@drohit-cb drohit-cb merged commit 2f184f5 into master Feb 11, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants