Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/update staking api #48

Merged
merged 2 commits into from
Feb 5, 2025
Merged

Feat/update staking api #48

merged 2 commits into from
Feb 5, 2025

Conversation

drohit-cb
Copy link
Contributor

What changed? Why?

This PR helps:

  1. Update the Go sdk with latest generated code to fix a breakage with the GetStakingContext API because of a recent addition of pending_claimable_balance

Error:

>> go run examples/ethereum/dedicated-eth-stake/main.go /Users/rohit/code/cb/staking/.coinbase_cloud_api_key_production.json 0xdb816889F2a7362EF242E5a717dfD5B38Ae849FE
2025/02/05 06:42:11 error getting stakeable balance: APIError{Code: unknown, Message: json: unknown field "pending_claimable_balance"}

I need to dig deeper into our client generation code, to see why this broke the SDK but for doing a forward-fix by updating the client with latest generated code fixes the issue and unblocks a customer.

  1. Fixes a small typo in example script.

Qualified Impact

@drohit-cb drohit-cb requested a review from marcin-cb February 5, 2025 15:04
@cb-heimdall
Copy link

cb-heimdall commented Feb 5, 2025

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@drohit-cb drohit-cb requested a review from djoyahoy February 5, 2025 15:04
@drohit-cb drohit-cb merged commit ef10a4f into master Feb 5, 2025
5 checks passed
@drohit-cb drohit-cb deleted the feat/update-staking-api branch February 5, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants